Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updateOverlayInformation not being called from displayPhoto: #99

Closed
ondrejhanak opened this issue Dec 9, 2015 · 3 comments
Closed

updateOverlayInformation not being called from displayPhoto: #99

ondrejhanak opened this issue Dec 9, 2015 · 3 comments
Labels
bug

Comments

@ondrejhanak
Copy link
Contributor

When you have a controller on screen with a set of photos and then call displayPhoto:, overlay info should be updated to display correct photo number.

This is my first GitHub issue, so maybe it is also a time for my firts one-liner PR?
@cdzombak
Copy link
Contributor

cdzombak commented Dec 9, 2015

This is my first GitHub issue, so maybe it is also a time for my firts one-liner PR?

I won't have time to look into this bug in the next several days, so if you'd like to submit a PR please do :)

@cdzombak cdzombak added the bug label Dec 9, 2015
@ondrejhanak
Copy link
Contributor Author

OK, PR #100 created.

@ondrejhanak ondrejhanak mentioned this issue Dec 9, 2015
Merged
@cdzombak
Copy link
Contributor

cdzombak commented Jan 4, 2016

fixed by #100.

@cdzombak cdzombak closed this as completed Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdzombak @ondrejhanak