Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reliably catch compile/prove discrepancies #629

Closed
mitschabaude opened this issue Dec 5, 2022 · 2 comments · May be fixed by #1363
Closed

Reliably catch compile/prove discrepancies #629

mitschabaude opened this issue Dec 5, 2022 · 2 comments · May be fixed by #1363
Assignees
Labels
error-messages Issues about making error messages better ITN-zkApps-E2E-testing move-to-js Refactor parts of the OCaml portion to JS

Comments

@mitschabaude
Copy link
Collaborator

mitschabaude commented Dec 5, 2022

Follow-up to #624

  • Investigate why a discrepancy between compilation & proving caused an out of bounds error during the compute_witness in the Pickles wrap prover
  • Exactly identify what in that bug was the underlying problem, and what the course of downstream effects, at a low level
  • Find a way to identify this error earlier in the process, such that the error is more closely related to the cause
  • Reliably communicate the underlying problem to the user
@mimoo
Copy link
Contributor

mimoo commented Dec 5, 2022

Interesting, reading #498 it seems like we're trying to access a witness value as part of exists (witness generation) or as_prover (debug). I think without better errors this will be hard to debug, so if this not urgent perhaps we can wait on getting better errors first

@mitschabaude mitschabaude added move-to-js Refactor parts of the OCaml portion to JS error-messages Issues about making error messages better and removed berkeley-mainnet labels Jan 5, 2023
@mitschabaude
Copy link
Collaborator Author

mitschabaude commented Mar 28, 2023

This again cropped up as an important issue as several zkApp testers ran into these kinds of issues and they proved to be extremely hard to debug. A simple first step would be to reliably tell the user if there is a compile / prover discrepancy. It seems to do that we'd need to create a constraint system in the prover and return its digest, in a way that it can be used if the proof fails to identify this as a problem

@mitschabaude mitschabaude added user-priority Issues that seem high priority to one or more users ITN-zkApps-E2E-testing and removed user-priority Issues that seem high priority to one or more users labels Mar 28, 2023
@mitschabaude mitschabaude self-assigned this Jan 11, 2024
@Trivo25 Trivo25 closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error-messages Issues about making error messages better ITN-zkApps-E2E-testing move-to-js Refactor parts of the OCaml portion to JS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants