fix[event.schema.json]: query_id optional #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzonthemtn
approved these changes
Aug 14, 2024
|
Thanks @AnkitSiva! |
|
I can see this argument... At this point in time, it's probably better for us to be laxer in our validation versus overly strict as we gain more "real world" use. So agreed. |
|
as part of this, also making sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is again a small, backwards-compatible change so I am not writing up the full RFC for this. The
query_idfield is required in the current schema. However, the scope of UBI is broader than only tracking the behavior of users after a search is performed. Indeed, the demo tracks user data before searches and writes an empty query ID to the index. This PR fixes that antipattern of a user writing an empty value to a required field.Fixes this issue