Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROS2] The Camera Sensor faces a different direction than the standard O3DE camera. #742

Open
knicked opened this issue Jul 31, 2024 · 2 comments
Labels
sig/simulation Categorizes an issue or PR as relevant to SIG Simulation triage/needs-inforamtion Indicates an issue needs more information in order to triage

Comments

@knicked
Copy link
Contributor

knicked commented Jul 31, 2024

The ROS2 Camera Sensor component appears to be facing the +Z direction, while the standard O3DE Camera component placed on the same entity faces the +Y direction. This makes it impossible to use the Viewport Camera Selector tool to adjust the ROS2 camera sensor placement.

image

Yellow: Standard O3DE Camera frustum.
Cyan: ROS2 Camera Sensor frustum placed on the same entity.

Describe the solution you'd like
Make the ROS2 Camera Sensor component face the same direction as the standard Camera component.

@knicked knicked added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 31, 2024
@jhanca-robotecai jhanca-robotecai added sig/simulation Categorizes an issue or PR as relevant to SIG Simulation and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 31, 2024
@michalpelka
Copy link
Contributor

ROS 2 camera follows https://www.ros.org/reps/rep-0103.html :
image which is standard in image processing. O3DE camera does not follow this convention.
Changing ROS 2 camera direction will break compatibility with REP-103 and will force simulation user to adjust it outside simulation

@michalpelka michalpelka added triage/needs-inforamtion Indicates an issue needs more information in order to triage and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 22, 2024
@michalpelka
Copy link
Contributor

This issue needs some investigation w.r.t SDF importer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/simulation Categorizes an issue or PR as relevant to SIG Simulation triage/needs-inforamtion Indicates an issue needs more information in order to triage
Projects
None yet
Development

No branches or pull requests

3 participants