Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace getargspec with getfullargspec #663

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

mnecas
Copy link
Member

@mnecas mnecas commented Jan 18, 2023

Fixes: #659
The getargspec was supported in python 2 and removed in python 3.11.
The alternative is getfullargspec, which is in all python 3 versions.

Signed-off-by: Martin Nečas <necas.marty@gmail.com>
Signed-off-by: Martin Perina <mperina@redhat.com>
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mwperina mwperina merged commit 9f9edc1 into oVirt:master Jan 18, 2023
mwperina added a commit to mwperina/ovirt-ansible-collection that referenced this pull request Jan 24, 2023
* Replace getargspec with getfullargspec

Signed-off-by: Martin Nečas <necas.marty@gmail.com>

* Add changelog

Signed-off-by: Martin Perina <mperina@redhat.com>

Signed-off-by: Martin Nečas <necas.marty@gmail.com>
Signed-off-by: Martin Perina <mperina@redhat.com>
Co-authored-by: Martin Perina <mperina@redhat.com>
mwperina added a commit that referenced this pull request Jan 24, 2023
* Replace getargspec with getfullargspec

Signed-off-by: Martin Nečas <necas.marty@gmail.com>

* Add changelog

Signed-off-by: Martin Perina <mperina@redhat.com>

Signed-off-by: Martin Nečas <necas.marty@gmail.com>
Signed-off-by: Martin Perina <mperina@redhat.com>
Co-authored-by: Martin Perina <mperina@redhat.com>

Signed-off-by: Martin Nečas <necas.marty@gmail.com>
Signed-off-by: Martin Perina <mperina@redhat.com>
Co-authored-by: Martin Nečas <necas.marty@gmail.com>
@mnecas mnecas mentioned this pull request Jan 24, 2023
@mnecas mnecas mentioned this pull request Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants