From 7620cfdf9e0812bf7f5ab6bbc48ea3c2eaf01a23 Mon Sep 17 00:00:00 2001 From: Martin Perina Date: Mon, 23 Jan 2023 10:23:51 +0100 Subject: [PATCH] Fix double quote issue when creating gluster brick The issue is a regression caused by ansible-list changes in https://github.com/oVirt/ovirt-engine/pull/658 Signed-off-by: Martin Perina Fixes: https://github.com/oVirt/ovirt-engine/issues/804 --- .../project/roles/gluster-brick-create/tasks/main.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/packaging/ansible-runner-service-project/project/roles/gluster-brick-create/tasks/main.yml b/packaging/ansible-runner-service-project/project/roles/gluster-brick-create/tasks/main.yml index 659a32693b9..e8f14799e38 100644 --- a/packaging/ansible-runner-service-project/project/roles/gluster-brick-create/tasks/main.yml +++ b/packaging/ansible-runner-service-project/project/roles/gluster-brick-create/tasks/main.yml @@ -55,8 +55,8 @@ # rc 5 = Logical Volume 'name' already exists in volume group. - name: Create a LV thinpool ansible.builtin.command: > - "lvcreate -l 100%FREE --chunksize {{ lv_chunksize }} --poolmetadatasize {{ pool_metadatasize }} --zero n - --type thin-pool --thinpool {{ lvname }}_pool {{ vgname }}" + lvcreate -l 100%FREE --chunksize {{ lv_chunksize }} --poolmetadatasize {{ pool_metadatasize }} --zero n + --type thin-pool --thinpool {{ lvname }}_pool {{ vgname }} register: resp failed_when: resp.rc not in [0, 5] changed_when: resp.rc == 0 @@ -74,8 +74,9 @@ # rc 1 = Filesystem already exists - name: Create an xfs filesystem ansible.builtin.command: > - "mkfs.xfs -f -K -i size=512 -n size=8192 {% if 'raid' in disktype %} -d sw={{ diskcount }},su={{ stripesize }}k - {% endif %} /dev/{{ vgname }}/{{ lvname }}" + mkfs.xfs -f -K -i size=512 -n size=8192 + {% if 'raid' in disktype %} -d sw={{ diskcount }},su={{ stripesize }}k {% endif %} + /dev/{{ vgname }}/{{ lvname }} register: resp failed_when: resp.rc not in [0, 1] changed_when: resp.rc == 0