Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: Add amt_ws fence agent support #810

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

mmartinv
Copy link
Contributor

@mmartinv mmartinv commented Feb 1, 2023

Support Intel® Active Management Technology (Intel® AMT) for host power management.

Signed-off-by: Miguel Martín mmartinv@redhat.com

@sandrobonazzola
Copy link
Member

@mmartinv I'm targeting this for oVirt 4.6.0, if there's some urgency to get it earlier please let me know.

@sandrobonazzola sandrobonazzola added this to the ovirt-4.6.0 milestone Feb 9, 2023
@sandrobonazzola
Copy link
Member

/ost

Copy link
Member

@barpavel barpavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but better have more eyes looking on it and approving the PR.
I assume it was tested by you? :) If so, I believe adding a verified label together with a short description of the testing scenario(s) is a good idea to increase reviewer's / code owner's confidence.

Copy link
Member

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review @ahadas comments

@mmartinv mmartinv force-pushed the enable-amt-ws-fence-agent branch 2 times, most recently from fb7d556 to d431cc3 Compare September 19, 2023 16:28
Support Intel® Active Management Technology (Intel® AMT) for
host power management.

Signed-off-by: Miguel Martín <mmartinv@redhat.com>
Signed-off-by: Arik Hadas <ahadas@redhat.com>
Copy link
Member

@ahadas ahadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmartinv I've changed the line that updates VdsFenceType to apply the addition of amt_ws also to cluster levels 4.4-4.7, please double check me. if that part is fine then we can merge this PR

@ahadas
Copy link
Member

ahadas commented Sep 28, 2023

got confirmation from @mmartinv

@ahadas ahadas merged commit 504baab into oVirt:master Sep 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants