During VM import from SD, exclude shared disk when iterating over disk snapshots #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhaOracle
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch,
smelamud,
didib and
ljelinkova
as code owners
shubhaOracle
force-pushed
the
import-shared-disk-snap
branch
from
9f095d2
to
9d9498d
Compare
…k snapshots. Signed-off-by: Shubha Kulkarni shubha.kulkarni@oracle.com Signed-off-by: ShubhaOracle <Shubha.kulkarni@oracle.com>
shubhaOracle
force-pushed
the
import-shared-disk-snap
branch
from
9d9498d
to
421885d
Compare
|
Requesting Reviews |
bennyz
approved these changes
Mar 15, 2024
|
Requesting Reviews/Approval |
1 similar comment
|
Requesting Reviews/Approval |
|
Merging based on previous approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
Issue:
When importing VM from SD, if VM has snapshot/s and a shared disk attached, a blank snapshot is created upon import.
Steps to reproduce:
- "2023-12-13 18:37:10,426-05 ERROR [org.ovirt.engine.core.bll.exportimport.ImportVmFromConfigurationCommand] (EE-ManagedThreadFactory-engine-Thread-18176) [a75c5669-6676-4d7d-ab3d-aace0d938d5e] Command 'org.ovirt.engine.core.bll.exportimport.ImportVmFromConfigurationCommand' failed: CallableStatementCallback; SQL [{call insertsnapshot(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)}]; ERROR: duplicate key value violates unique constraint "pk_snapshots""The issue happens since shared disk is considered as snapshot the during import and entry is added to the snapshots table
Are you the owner of the code you are sending in, or do you have permission of the owner?
[y/n] n
Signed-off-by: Shubha Kulkarni shubha.kulkarni@oracle.com