From 91ab7fdad6f1326a8fc14bc14b514f53d93c4d2b Mon Sep 17 00:00:00 2001 From: Milan Zamazal Date: Fri, 14 Oct 2022 17:31:58 +0200 Subject: [PATCH] core: Fix NullPointerException in ExtractOvaCommand --- .../ovirt/engine/core/bll/exportimport/ExtractOvaCommand.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExtractOvaCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExtractOvaCommand.java index bbab14ca4a9..95a604efdc8 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExtractOvaCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExtractOvaCommand.java @@ -238,11 +238,11 @@ private void storeExternalData(String stdout) { .filter(s -> !StringUtils.isEmpty(s)).map(s -> s.split("=", 2)) .collect(Collectors.toMap(part -> part[0], part -> new SecretValue(part[1]))); SecretValue tpmData = externalData.get("tpm"); - if (!StringUtils.isEmpty(tpmData.getValue())) { + if (tpmData != null && !StringUtils.isEmpty(tpmData.getValue())) { vmDao.updateTpmData(getVmId(), tpmData, null); } SecretValue nvramData = externalData.get("nvram"); - if (!StringUtils.isEmpty(nvramData.getValue())) { + if (nvramData != null && !StringUtils.isEmpty(nvramData.getValue())) { vmDao.updateNvramData(getVmId(), nvramData, null); } }