Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "handle" to "cookie" in nbd client #185

Open
nirs opened this issue Mar 4, 2023 · 0 comments
Open

Rename "handle" to "cookie" in nbd client #185

nirs opened this issue Mar 4, 2023 · 0 comments
Labels
good first issue Good issue for a new contributor

Comments

@nirs
Copy link
Member

nirs commented Mar 4, 2023

Following this NBD patch:
https://lists.debian.org/nbd/2023/03/msg00009.html

The term handle is confusing with handle_* functions. Renaming it will make it easier
to navigate and search the code.

Lets wait until this merged upstream, since current code matches the NBD spec:
https://github.com/NetworkBlockDevice/nbd/blob/master/doc/proto.md
@nirs nirs added the good first issue Good issue for a new contributor label Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good issue for a new contributor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nirs