Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeouts in backup tests #97

Open
aesteve-rh opened this issue Jul 14, 2022 · 3 comments
Open

Fix timeouts in backup tests #97

aesteve-rh opened this issue Jul 14, 2022 · 3 comments
Labels
tests Issue or improvements in the tests

Comments

@aesteve-rh
Copy link
Member

These tests run a real vm, and github does not support hardware acceleration, so
we run with emulation (tcg). This is very slow, so the host running the test is
overloaded, it can time out.

Fails in test_incremental_backup_guest take ~20 seconds, using 60 seconds timeout.
Using 120 seconds will likely eliminate these random failures

If not, maybe this is a bug in the code communicating with the vms using serial port:

class Guest:

Ideally, we need to log what we see on the wire in debug level, so when this code fails,
we can understand if the issue was unexpected input from the guest or too slow guest.

@aesteve-rh aesteve-rh added the tests Issue or improvements in the tests label Jul 14, 2022
@sri-srikanth
Copy link
Contributor

Hey!
I am a Computer Science student at the University of Texas at Austin taking a Virtualization course. My two groupmates and I were wondering if we could contribute to resolving this issue. Please let me know if this would be possible and we can get started.

@aesteve-rh
Copy link
Member Author

Hello @sri-srikanth ,

I think this may not be a good first issue as it is a timeout that happened some time ago in one CI test.
It is not easy to catch or verify. IIRC the issue was more meant to track it in case we saw it failing again.

But you can pick any other issue in the good first issue tag: https://github.com/oVirt/ovirt-imageio/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22

I would be more than happy to help in any of them :)

@sri-srikanth
Copy link
Contributor

sri-srikanth commented Mar 24, 2023

Hello @sri-srikanth ,

I think this may not be a good first issue as it is a timeout that happened some time ago in one CI test. It is not easy to catch or verify. IIRC the issue was more meant to track it in case we saw it failing again.

But you can pick any other issue in the good first issue tag: https://github.com/oVirt/ovirt-imageio/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22

I would be more than happy to help in any of them :)

Ah, makes sense. Thank you for informing me. I'll reach out if I have any questions about other issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issue or improvements in the tests
Projects
None yet
Development

No branches or pull requests

2 participants