Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better solution for finding the start of "parent expressions" #9

Open
oakmac opened this issue Nov 8, 2015 · 3 comments
Open

better solution for finding the start of "parent expressions" #9

oakmac opened this issue Nov 8, 2015 · 3 comments

Comments

@oakmac
Copy link
Owner

oakmac commented Nov 8, 2015

Right now we are assuming that an open paren as the first character of a line is the start of a new expression. There are circumstances where this is not true (example: multi-line strings) and will cause odd behavior from the main Parinfer algorithm.

Need to find a better solution here.

@jasongilman
Copy link

I'm the maintainer of Proto REPL. I had a similar issue and found that using Atom can tell you the context for any code by using scopes. See https://github.com/jasongilman/proto-repl/blob/master/lib/editor-utils.coffee#L45

@oakmac
Copy link
Owner Author

oakmac commented Nov 12, 2015

Awesome! Thank you for posting this.

@oakmac
Copy link
Owner Author

oakmac commented Jan 7, 2016

sublime-text-parinfer has some interesting discussion on the "parent expression hack"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants