Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEC-73] Change npm version in engine field to get dependabot running again #2484

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

orangemug
Copy link
Contributor

@orangemug orangemug commented Jun 10, 2024

Description

As mentioned in dependabot/dependabot-core#9277 (comment) hopefully changing the npm version in the engine field to >=9.6.5 will get dependabot running again and creating PRs.

The original error we're trying to overcome is

Dependabot uses Node.js v20.14.0
 and NPM 10.7.0
. Due to the engine-strict setting, the update will not succeed.

Issue(s)

FEC-73

How to test

We can't test the actual fix prior to merge, hopefully it'll work once merged and dependabot will start working again.

With regards to the deployed code, nothing should change as our github action workflows run with particular versions of node/npm anyway.

@orangemug orangemug requested a review from njblore June 10, 2024 08:56
Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for oak-web-application ready!

Name Link
🔨 Latest commit 1289cdf
🔍 Latest deploy log https://app.netlify.com/sites/oak-web-application/deploys/6666bfbcad9fe000087fe43c
😎 Deploy Preview https://deploy-preview-2484--oak-web-application.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for owa-storybook ready!

Name Link
🔨 Latest commit 1289cdf
🔍 Latest deploy log https://app.netlify.com/sites/owa-storybook/deploys/6666bfbc03e7590008877088
😎 Deploy Preview https://deploy-preview-2484--owa-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@orangemug orangemug merged commit 6fb698a into main Jun 10, 2024
30 checks passed
@orangemug orangemug deleted the fix/FEC-73-dependabot-fix branch June 10, 2024 09:51
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.453.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants