Question about send behaviour

[schuelermine]

I have a few questions about the behaviour of send.

What happens when send fails in various ways? Will the response object remain unwritable?
Does send resolve .. segments in paths? If so, will it ever backtrack beyond the root?
Does send recognize trailing slashes and instead serve the index of the directory, or is the index parameter only for the root?

[somebody1234]

What happens when send fails in various ways? Will the response object remain unwriteable?

not sure what you mean by it being unwriteable, given that response is never Readonly afaict.

you should be able to just wrap in a try/catch and handle failure cases in the catch block.

oak/send.ts

Lines 243 to 246 in 4de406a

	if (err instanceof Deno.errors.NotFound) {
	throw createHttpError(404, err.message);
	}
	throw createHttpError(500, err.message);

Does send resolve .. segments in paths? If so, will it ever backtrack beyond the root?

yes to the first, no to the second:

oak/send.ts

Line 195 in 4de406a

path = resolvePath(root, path);

oak/util.ts

Lines 316 to 319 in 4de406a

	// path outside root
	if (UP_PATH_REGEXP.test(normalize("." + sep + path))) {
	throw createHttpError(403);
	}

Does send recognize trailing slashes and instead serve the index of the directory, or is the index parameter only for the root?

the index parameter is a default filename to serve for directories, usually index.html:

oak/send.ts

Lines 234 to 236 in 4de406a

	if (stats.isDirectory) {
	if (format && index) {
	path += `/${index}`;

[schuelermine]

AFAIK writing to context.request.body makes it readonly, even if the write fails.

app.use(async (context, next) => {
    try {
        context.request.body = (() => {throw null})() as any;
    } catch {
        await next();
    }
})

app.use(context => {
    context.response.body = ""
})

↑ this will fail

[schuelermine]

wait no

[schuelermine]

that seems to work, fine
I don’t know why it didn’t work in another situation where I tried something similar