Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify the schema of health scope output #151

Open
wonderflow opened this issue Sep 17, 2019 · 3 comments
Open

specify the schema of health scope output #151

wonderflow opened this issue Sep 17, 2019 · 3 comments
Assignees
Milestone

Comments

@wonderflow
Copy link
Member

wonderflow commented Sep 17, 2019

Now we have defined the spec of health scope, but I can't find the output of health spec. Do we need to specify the schema of health scope output? Because we hope other trait can use the health scope output to make decision.

Maybe we can make the output something like this:

{"state":"unhealthy/healthy/bad","components":{"comp1":"healthy","comp2":"unhealthy"}}
  1. the output must give the health state of the instance
  2. the output must include health details of component

/cc @hongchaodeng

@hongchaodeng
Copy link
Member

I totally agree.
I think the status should go in the instance of app-scope which is under development in https://github.com/microsoft/hydra-spec/pull/147.

@hongchaodeng hongchaodeng self-assigned this Sep 17, 2019
@suhuruli
Copy link
Contributor

When you say output you mean when a user or other part of Hydra queries the health scope, we agree on a common output?

@hongchaodeng
Copy link
Member

@suhuruli Yes.

@technosophos technosophos added this to the backlog milestone Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants