Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

Exceptions handling for stoi, stol, stof, stod in whole stage code gen #617

Closed
PHILO-HE opened this issue Dec 8, 2021 · 3 comments
Closed

Exceptions handling for stoi, stol, stof, stod in whole stage code gen #617

PHILO-HE opened this issue Dec 8, 2021 · 3 comments
Assignees
@PHILO-HE
Labels
bug Something isn't working

Comments

@PHILO-HE
Copy link
Collaborator

PHILO-HE commented Dec 8, 2021 •
edited
Loading

This issue can be reproduced by Q38.
@PHILO-HE PHILO-HE added the bug Something isn't working label Dec 8, 2021
@PHILO-HE PHILO-HE self-assigned this Dec 8, 2021
@zhouyuan
Copy link
Collaborator

maybe using sprintf?

@github-actions github-actions bot mentioned this issue Dec 23, 2021
Merged
@PHILO-HE
Copy link
Collaborator Author

These functions are used to cast string type to numeric types. In #655, we added exception handling to set validity to false. Thus, null result will be returned in such cases.

@PHILO-HE
Copy link
Collaborator Author

Fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@PHILO-HE PHILO-HE

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhouyuan @PHILO-HE