This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-97] optimize null check and refactor sort kernels #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zhouyuan
reviewed
Feb 19, 2021
rui-mo
force-pushed
the
wip_sort_null
branch
from
9bcf3a1
to
72d5a7c
Compare
rui-mo
changed the title
|
|
|
|
zhouyuan
reviewed
Feb 20, 2021
| used to do comparison. | ||
| If partition is required, null, NaN(for double and float only) and valid value are | ||
| partitioned before sorting. | ||
| FIXME: 1. datatype change after projection is not supported in SortInplaceKernel. |
There was a problem hiding this comment.
great notes for reviewers 👍
|
|
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr
fixes #97
How was this patch tested?
locally tested