-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor revision for TC meeting 2024-11-27 #839
Open
tschmidtb51
wants to merge
54
commits into
master
Choose a base branch
from
editor-revision-2024-11-27
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tschmidtb51
commented
Dec 2, 2024
- fixes Add Sharing Groups #705
- fixes Clarification on why test case 6-1-31-12 in CSAF2.0 is supposed to be valid #825
- fixes Clarify requirement 19: ASCII vs. Binary signature #797
- fixes Clarify quotes in changes.csv #768
- addresses parts of Simply datetime values (timestamps) by moving to RFC3339 #469
- fixes Clarify the inclusion of open-source projects for the value vendor in 3.2.1.8.1 Document Property - Publisher - Category #790
- update dates - insert new revision for tracking
- addresses parts of #705 - add `sharing_group` to JSON schema
Seed Editor revision 2024-11-27
- addresses parts of #705 - adapt prose to reflect sharing group changes - add RFC 9562 to normative references - add RFC 4122 to informative references
- addresses parts of #705 - add mandatory test to prevent usage of Max UUID in other TLP than CLEAR - add invalid examples - add valid examples - adapt testcases list and schema
- addresses parts of #705 - add mandatory test to prevent usage of reserved names - improve wording - add invalid examples - add valid examples - adapt testcases list and schema
- addresses parts of #705 - add mandatory test to prevent usage other UUID than Max UUID in TLP:CLEAR - add invalid examples - add valid examples - adapt testcases list and schema
- addresses parts of #705 - swap order of 6.1.40 and 6.1.41 - adapt testfiles
- addresses parts of #705 - add mandatory test to enforce usage of sharing group names - add invalid examples - add valid examples - adapt testcases list and schema
- addresses parts of #705 - add additional valid examples for 6.1.41
- addresses parts of #705 - add rule about the relationship between sharing group ID and `/document/tracking/id`
- addresses parts of #705 - correct link format
- addresses parts of #705 - add optional test to discourage usage of Max UUID - add invalid example - add valid examples - adapt testcases list and schema
- addresses parts of #705 - add optional test to discourage usage of Nil UUID - add invalid example - add valid examples - adapt testcases list and schema
- addresses parts of #705 - add optional test to discourage usage sharing group with TLP:CLEAR - add invalid example - add valid examples - adapt testcases list and schema
- addresses parts of #705 - add new files into bind.txt
- addresses parts of #705 - add suggestions for quick fixes throughout the sharing group tests
- addresses parts of #705 - add guidance of size for UUIDs - swap date and URI to make it alphabetic amongst the "special" strings
- addresses parts of #825 - improve wording in prose Co-authored-by: Christian Banse <christian.banse@aisec.fraunhofer.de>
- addresses parts of #825 - add additional valid example
- resolves #797 - add explicit statements about OpenPGP signatures and key files being ASCII armored
Co-authored-by: Christian Banse <oxisto@aybaze.com>
- addresses parts of #768 - change changes.csv to non-quoted - clarify wording - add normative reference to RFC 4180
Clarify test 6.1.31
Update Editor Revision 2024-11-27 from master
Mandatory test to check `date-time` format
`changes.csv`: Clarify quoting
ASCII armored OpenPGP
- addresses parts of #790 - add open source projects
Clarify Inclusion of Open Source
- update dates - insert new revision for tracking
- addresses parts of #825 - improve wording in prose Co-authored-by: Christian Banse <christian.banse@aisec.fraunhofer.de>
- addresses parts of #825 - add additional valid example
Co-authored-by: Christian Banse <oxisto@aybaze.com>
- addresses parts of #768 - change changes.csv to non-quoted - clarify wording - add normative reference to RFC 4180
- resolves #797 - add explicit statements about OpenPGP signatures and key files being ASCII armored
- addresses parts of #790 - add open source projects
Sharing groups
tschmidtb51
added
editor-revision
already worked on in the editor revision
csaf 2.1
csaf 2.1 work
labels
Dec 2, 2024
Note: Some commits appear "doubled" due to a rebase... |
- fixed file numbering (maintainability) - fixed example labels - added section and example labels for new and changed sections - added explicit section link for title containing TLP:CLEAR (ease of use) - updated binder with changed file names - generated label maps and inversions - derived HTML and single markdown file delivery items Signed-off-by: Stefan Hagen <stefan@hagen.link>
sthagen
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Note: The structural changes to align with the latest fashion will be in a dedicated change set / peer review as to not mix material with presentational changes.
santosomar
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.