Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor revision for TC meeting 2024-10-30 #819

Merged
merged 49 commits into from
Nov 18, 2024
Merged

Editor revision for TC meeting 2024-10-30 #819

merged 49 commits into from
Nov 18, 2024

Conversation

tschmidtb51
Copy link
Contributor

tschmidtb51 and others added 30 commits October 17, 2024 23:19
@tschmidtb51
Editor revision 2024-10-30
fc7a143 
- update dates
- insert new revision for tracking
@tschmidtb51
CPE
2ba8975 
- resolves #796
- add note that CPE 2.2 and 2.3 is supported
@tschmidtb51
Semantic Versioning
392cc47 
- addresses parts of #785
- fix incorrect examples
- add new invalid examples
@tschmidtb51
Redirects
6bd3ac0 
- resolves #798
- add sentence about max redirects
@tschmidtb51
Merge pull request #801 from tschmidtb51/versioning
2d4f104 
Semantic Versioning - fix examples
@tschmidtb51
Merge pull request #800 from tschmidtb51/cpe
bbdceab 
CPE
@tschmidtb51
Merge pull request #799 from tschmidtb51/editorial-2024-10-30
13237a3 
Seed Editor revision 2024-10-30
@tschmidtb51
Optional Patch
0ad4ed7 
- addresses parts of #563
- add value "optional_patch"
- adapt prose
@tschmidtb51
Optional Patch
3dc2345 
- addresses parts of #563
- add conversion rule for CVRF
- add conversion rule from CSAF 2.0
@tschmidtb51
Fix planned
b5b4f0e 
- addresses parts of #662
- add value `fix_planned` as remediation category
- adapt prose
- restructure mutually exclusive categories
@tschmidtb51
Fix planned
60137b8 
- addresses parts of #662
- add conversion rule from CVRF
- add conversion rule from CSAF 2.0
- fix format mistake
@tschmidtb51
Search vs Filter
063878a 
- fixes #730
- define filter and search
@tschmidtb51
Remediation categories
6e78e52 
- addresses parts of #541, #662, #563
- clarify that reference of products can be direct or indirect
@tschmidtb51
Contradicting Remediations
22bfacb 
- addresses parts of #541, #662, #563
- add mandatory test for contradicting remediations
- add invalid examples
- add valid examples
@tschmidtb51
Remediation categories
675a980 
- addresses parts of #541, #662, #563
- remove duplicate notes about mutually exclusive categories
- add table for contradicting product status group remediation category combinations
@tschmidtb51
Contradicting Product Status vs Remediation
05502f8 
- addresses parts of #541, #662, #563
- add mandatory test for contradicting Product status remediations combinations
- add invalid examples
- add valid examples
@tschmidtb51
Contradicting Product Status vs Remediation
a274571 
- addresses parts of #541, #662, #563
- fix spelling mistake
- improve wording
- clarify that this also applies to indirect relationships through product groups
@tschmidtb51
Discouraged Product Status Remediation Combination
7e03b04 
- addresses parts of #541, #662, #563
- add optional test for discouraged product status remediation combinations
- add invalid examples
- add valid examples
@tschmidtb51
Contradicting Remediations
026b814 
- addresses parts of #541, #662, #563
- correct example
- add valid example
- add invalid example
@tschmidtb51
Mandatory TLP 2.0
79ceffe 
- addresses parts of #633
- mark test 6.2.10 as obsolete and present reasoning
- remove test files for 6.2.10
- adapt test schema and test data list
@tschmidtb51
Mandatory TLP 2.0
f169954 
- addresses parts of #633
- clarify wording regarding required TLP
@tschmidtb51
Revert "Code block syntax"
9b2c203
@tschmidtb51
Mandatory TLP 2.0
a038653 
- addresses parts of #633
- clarify in the wording that it is required, not mandatory to avoid confusion with mandatory tests
@tschmidtb51
Date-time
2c8ed76 
- addresses parts of #469
- add section on Date and Time to explain the rules
@tschmidtb51
Date-time
ebf8f28 
- addresses parts of #469
- specify . as frac-sec separator
- explicitly state no empty timezones
- add reference to ABNF of RFC 3339 section 5.6
@tschmidtb51
Requirements 9 and 10
f826d1e 
- fixes #811
- add comment that not redirects are allowed in requirement 9 and 10
@tschmidtb51
RFC 9116
8ec5d8f 
- addresses parts of #318
- reflect current state of CSAF field in security.txt
@sthagen
Nit: changed allow to allowed
08255a4
@tschmidtb51
CSAF Downloader
2087c2f 
- addresses parts of #674
- add conformance target CSAF Downloader
@sthagen
Review feedback
dd92a3c 
- instead of fixing the wrong form of enforce removed the enforcement as the schema can only require (the validator may enforce).
- calmed the waters even more by removing the word confusion and focusing on documentation and numbering of remaining sections
tschmidtb51 and others added 12 commits October 26, 2024 00:08
@tschmidtb51
Date-time
bf9393b 
- addresses parts of #469
- move RFC 3339 and ISO 8601 to normative references
@tschmidtb51
Date-time
ec40176 
- addresses parts of #469
- correct format
- add filename to etc/bind.txt
@tschmidtb51
Date-time
2b508b1 
- addresses parts of #469
- link section in conformance targets
@tschmidtb51
Merge branch 'editor-revision-2024-10-30' into remediation-categories
cc8ba4f
@tschmidtb51
Tests
a47d20c 
- addresses parts of #541
- add missing files to bind.txt
@tschmidtb51
Remediation categories
ca7fe94 
- addresses review comments from #807
- convert unnecessary upper case to lower case
@sthagen
Not convinced, but grammatically correct ;-)
ebf0e9d
@sthagen @tschmidtb51
review adjustments
a3b72ba 
Co-authored-by: tschmidtb51 <65305130+tschmidtb51@users.noreply.github.com>
@santosomar
Merge pull request #807 from tschmidtb51/remediation-categories
1475f37 
Remediation categories
@santosomar
Merge pull request #805 from tschmidtb51/editorial-2024-10-30
0c2ecbe 
Search vs Filter
@santosomar
Merge pull request #810 from tschmidtb51/date-time
58bc0d5 
Date-time
@tschmidtb51
Merge pull request #814 from tschmidtb51/csaf-downloader
9b5346c 
CSAF Downloader
@tschmidtb51 tschmidtb51 added editor-revision already worked on in the editor revision csaf 2.1 csaf 2.1 work labels Oct 30, 2024
@tschmidtb51 tschmidtb51 requested a review from sthagen October 30, 2024 23:50
@tschmidtb51 tschmidtb51 self-assigned this Oct 30, 2024
tschmidtb51 and others added 3 commits October 31, 2024 00:51
@tschmidtb51
Editorial
12d4d08 
- add full stop at the end
@sthagen
Fixed sec ref, updated maps, and rendered md/html
0943cfd 
- nit: fixed reference to new/reborn date and time section
- updated the mappings for sections and examples
- rendered the user facing delivery items: single file markdown and html

Signed-off-by: Stefan Hagen <stefan@hagen.link>
@sthagen
Merge branch 'master' into editor-revision-2024-10-30
edcf624
sthagen
sthagen approved these changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tschmidtb51 tschmidtb51 added the motion This item has a motion pending label Nov 7, 2024
@tschmidtb51
Copy link
Contributor Author

Motion set by Thomas Schmidt and seconded by Justin Murphy: https://groups.oasis-open.org/discussion/motion-for-819

sthagen
sthagen approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@sthagen sthagen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SLGTM.

@tschmidtb51
Copy link
Contributor Author

No objections or discussions received. Motion therefore passed.

@tschmidtb51 tschmidtb51 merged commit 5c58320 into master Nov 18, 2024
10 checks passed
@tschmidtb51 tschmidtb51 removed the motion This item has a motion pending label Nov 18, 2024
@sthagen sthagen deleted the editor-revision-2024-10-30 branch November 20, 2024 11:11
@santosomar santosomar added the motion_passed A motion has passed label Nov 27, 2024
@santosomar
Copy link
Contributor

The motion to accept the Editor Revision 2024-10-30 as suggested in #819 into our master branch has passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sthagen sthagen sthagen approved these changes

Assignees

@tschmidtb51 tschmidtb51

Labels
csaf 2.1 csaf 2.1 work editor-revision already worked on in the editor revision motion_passed A motion has passed
Projects
None yet
Milestone
No milestone
3 participants
@tschmidtb51 @santosomar @sthagen