Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODATA-1384 - Clarify usage of annotation qualifiers as references to hierarchies #125

Merged
merged 98 commits into from
Mar 3, 2022
Merged

ODATA-1384 - Clarify usage of annotation qualifiers as references to hierarchies #125

merged 98 commits into from
Mar 3, 2022

Conversation

GeraldKrause
Copy link
Contributor

No description provided.

HeikoTheissen
HeikoTheissen requested changes Jun 24, 2021
View reviewed changes
vocabularies/Org.OData.Aggregation.V1.xml Outdated Show resolved Hide resolved
vocabularies/Org.OData.Aggregation.V1.xml Outdated Show resolved Hide resolved
vocabularies/Org.OData.Aggregation.V1.xml Outdated Show resolved Hide resolved
vocabularies/Org.OData.Aggregation.V1.xml Outdated Show resolved Hide resolved
vocabularies/Org.OData.Aggregation.V1.xml Outdated Show resolved Hide resolved
vocabularies/Org.OData.Aggregation.V1.xml Outdated Show resolved Hide resolved
vocabularies/Org.OData.Aggregation.V1.xml Outdated Show resolved Hide resolved
vocabularies/Org.OData.Aggregation.V1.xml Outdated Show resolved Hide resolved
vocabularies/Org.OData.Aggregation.V1.xml Outdated Show resolved Hide resolved
vocabularies/Org.OData.Aggregation.V1.xml Outdated Show resolved Hide resolved
@HeikoTheissen
Copy link
Contributor

Instead of having Nodes and Hierarchy in every function, consider using a single parameter of type Edm.String that contains an Edm.AnnotationPath to the RecursiveHierarchy annotation. You could have a TypeDefinition for that, in which you explain only once that this defines a hierarchy that is evaluated by the function.

@HeikoTheissen HeikoTheissen mentioned this pull request Jun 25, 2021
Merged
HeikoTheissen
HeikoTheissen previously requested changes Dec 13, 2021
View reviewed changes
vocabularies/Org.OData.Aggregation.V1.xml Outdated Show resolved Hide resolved
vocabularies/Org.OData.Aggregation.V1.xml Outdated Show resolved Hide resolved
vocabularies/Org.OData.Aggregation.V1.xml Outdated Show resolved Hide resolved
HeikoTheissen
HeikoTheissen requested changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@HeikoTheissen HeikoTheissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the parameter name IncludeSelf in isancestor and isdescendant easier to grasp, and it is also analogous to the XPath axes ancestor-or-self and descendant-or-self.

vocabularies/Org.OData.Aggregation.V1.xml Outdated Show resolved Hide resolved
vocabularies/Org.OData.Aggregation.V1.xml Outdated Show resolved Hide resolved
@HeikoTheissen HeikoTheissen merged commit d7a1671 into aggregation-cs03-release-candidate Mar 3, 2022
@HeikoTheissen HeikoTheissen deleted the ODATA-1384 branch March 3, 2022 17:49
HeikoTheissen added a commit that referenced this pull request Oct 18, 2023
@HeikoTheissen
Changes to Aggregation vocabulary for CS03 (#178)
6cc0ce5 
* ODATA-1218 - Enhance hierarchy processing (#121)
* ODATA-1142 - resolved - Clarify MaxDistance is an optional parameter in hierarchy filter functions (#78)
* ODATA-1136 - resolved - Allow hierarchy filter functions for ancestors and descendants ... (#77)
* ODATA-1384 - Clarify usage of annotation qualifiers as references to hierarchies (#125)
* Digital/Physical -> Food/NonFood (#186)
* Aggregation voc - update descriptions: remove rollupall, add rolluprecursive  (#193)
* Preview on new transformations (#218)
* Changes resulting from OData-Aggr walkthrough (#191)
* remove commented-out Cycle term (#221)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeikoTheissen HeikoTheissen HeikoTheissen approved these changes

@ralfhandl ralfhandl ralfhandl approved these changes

Assignees
No one assigned
Labels
Aggregation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GeraldKrause @HeikoTheissen @ralfhandl