Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: We should use better names for screen sizes #555

Open
1 task done
csillag opened this issue Jun 19, 2023 · 0 comments
Open
1 task done

[Feature]: We should use better names for screen sizes #555

csillag opened this issue Jun 19, 2023 · 0 comments
Labels
feature New feature or request

Comments

@csillag
Copy link
Contributor

csillag commented Jun 19, 2023

Is there an existing issue for this?

  • I have searched the existing issues

SUMMARY

The current names we are using for screen sizes are misleading

DESCRIPTION

We have a hook useScreenSizes() for checking screen sizes. However, the values we are returning here don't mean what the names suggest they mean. For example we have isTable which does not mean that we are working with a tablet screen, but that we are working at most on a tablet screen, ie. either on a mobile or a tablet. The names should reflect that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant