Feature/ADF-1417/Upgrade to Node 18 #3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: views/package-lock.json views/package.json
Codecov Report
@@ Coverage Diff @@
## develop #3794 +/- ##
==========================================
Coverage 28.14% 28.14%
Complexity 10949 10949
==========================================
Files 922 922
Lines 32906 32906
==========================================
Hits 9260 9260
Misses 23646 23646 |
This was referenced May 2, 2023
1 task
shaveko
approved these changes
May 10, 2023
rgomeztao
approved these changes
May 10, 2023
…ith breaking changes
jsconan
force-pushed
the
feature/ADF-1417/upgrade-to-node18
branch
from
05a584c to
3a803bf
Compare
Conflicts: views/build/grunt/sass.js
Conflicts: views/js/loader/tao.min.js views/js/loader/tao.min.js.map
Version🚨 Your pull request contains a BREAKING CHANGE, please be sure to communicate it.
There are 1 BREAKING CHANGE, 0 feature, 3 fixes |
This was referenced May 12, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: ADF-1417 and ADF-1418
Requires:
views/package.jsononce the companion PRs have been merged and releasedviews/build/package.jsononce the companion PRs have been merged and releasedSummary
Update the dependencies in order to support further versions of Node
Details
To properly support Node 18, the dev dependencies had to be updated and aligned.
BREAKING CHANGE:
Note: The lock file was generated with
npm@6so it would also work seamlessly with Node 14.How to test
Note After switching to Node 18, you may need to erase the node_module folder, otherwise the error
>> Error: Could not locate the bindings filemay arise.