Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolving type metadata from URL and limit to HTTPS URLs #233

Closed
awoie opened this issue May 17, 2024 · 0 comments · Fixed by #272
Closed

Fix resolving type metadata from URL and limit to HTTPS URLs #233

awoie opened this issue May 17, 2024 · 0 comments · Fixed by #272
Assignees

Comments

@awoie
Copy link
Collaborator

awoie commented May 17, 2024

Current text:

In an SD-JWT VC, a URI in the vct claim can be used to express a type. If the type is a URL, metadata can be retrieved from the URL https:///.well-known/vct/, i.e., by inserting /.well-known/vct after the authority part of the URL.

Since well-known only applies to HTTPS URLs, we should limit the section to HTTPS URLs although other URLs would be still possible, e.g., ipfs://....

Additionally, also the <type> in https://<authority>/.well-known/vct/<type> is probably not correct since the type refers to the vct value itself which would not make sense to the full vct value here which would also include the scheme for instance.

I suggest we update the title to "From an HTTPS URL in the vct claim" and update the language to something like this:

If the vct value is an HTTPS URL, Type Metadata can be retrieved from the URL constructed by inserting "/.well-known/vct" after the authority part of the URL in the vct value. For example, a vct value of "https://example.com/foo/bar/mytype" would result in "https://example.com/.well-known/vct/foo/bar/mytype".

@awoie awoie changed the title Fix esolving type metadata from URL and limit to HTTPS URLs Fix resolving type metadata from URL and limit to HTTPS URLs May 17, 2024
@bc-pi bc-pi linked a pull request Nov 18, 2024 that will close this issue
@bc-pi bc-pi closed this as completed in #272 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants