Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes and removals for Oban 3.0 [HOLD] #849

Open
18 tasks
sorentwo opened this issue Feb 17, 2023 · 1 comment
Open
18 tasks

Changes and removals for Oban 3.0 [HOLD] #849

sorentwo opened this issue Feb 17, 2023 · 1 comment
Labels
area:oss Related to Oban OSS kind:chore Internal improvements

Comments

@sorentwo
Copy link
Member

sorentwo commented Feb 17, 2023

To be changed before Oban 3.0:

Defaults

  • Use scheduled_at as unique timestamp by default

Normalization

  • Normalize telemetry states from executor (success => completed, etc)
  • Normalize database states from drain_queue/1 (discard => discarded, success => completed, etc.)
  • Remove Oban.Migrations alias

Config

  • Remove :discard and {:discard, reason} return values
  • Remove top-level crontab option
  • Remove support for Oban.Queue.BasicEngine name
  • Remove support for Oban.Plugins.Stager config
  • Remove Oban.PostgresNotifier name
  • Remove Oban.Peers.Postgres name
  • Remove top-level circuit_backoff option
  • Remove use of DYNO for node name
  • Rename log to ecto_log, repo_log, or query_log

Plugins

  • Remove Repeater plugin
  • Remove Gossip plugin

Schema / Database

  • Collapse migrations

Queue

  • Remove producer telemetry event

Telemetry

  • Default to structured logs, not JSON in default logger

⚠️ This is for tracking purposes as we have no intention of releasing 3.0 soon. Please do not send PRs!

@sorentwo sorentwo added area:oss Related to Oban OSS kind:chore Internal improvements labels Feb 17, 2023
@yordis
Copy link
Contributor

yordis commented Jun 18, 2024

Adding some context,

The discarded state is for internal use and should strictly mean when a job exhausts all retries. Cancelled is the appropriate state instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:oss Related to Oban OSS kind:chore Internal improvements
Projects
None yet
Development

No branches or pull requests

2 participants