State-preserving file dialog and saveAs behaviour #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class uses QSettings save/restore its state and geometry, similarly to what is done for the main application window. Currently the state and geometry is always saved when the dialog is not spontaneusly hidden, even if the dialog is cancelled.
The new FileDialog allows saving/restoring its current state and geometry to/from settings. Closes obdasystems#145
Previous to this as a result of performing the saveAs action the active project would refer to the initial project file, which means that any subsequent save would still modify the original project file. This behaviour is different from what is typically found in the majority of other editing software, and can be confusing for the user. Starting with this commit, when performing saveAs, the new selected path becomes the active project file path, and any subsequent modification will apply to the new project file. Closes obdasystems#142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issues: