Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New lint: non-sealed trait added supertrait #441

Closed
Tracked by #5
obi1kenobi opened this issue Apr 25, 2023 · 1 comment · Fixed by #892
Closed
Tracked by #5

New lint: non-sealed trait added supertrait #441

obi1kenobi opened this issue Apr 25, 2023 · 1 comment · Fixed by #892
Labels
A-lint Area: new or existing lint E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.

Comments

@obi1kenobi
Copy link
Owner

obi1kenobi commented Apr 25, 2023 •
edited
Loading

Semver-major, because 3rd party types that used to impl the trait in the last version might not impl the new supertrait imposed in the new version.

Example breaking change in the real-world: https://github.com/awslabs/smithy-rs/pull/2577/files#diff-82252c5a4ad7e9d34be9254db1afe172d0f01c067b121de20ff7f7f29d7cf223L24
@obi1kenobi obi1kenobi mentioned this issue Apr 25, 2023
Open
@obi1kenobi obi1kenobi added A-lint Area: new or existing lint E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue. labels Apr 25, 2023
@obi1kenobi
Copy link
Owner Author

obi1kenobi commented Oct 12, 2023 •
edited
Loading

Requires checking whether a trait is sealed, which requires work on the adapter and isn't the best initial onboarding task.

EDIT: This work has been completed, and this lint is ready to be implemented!

@obi1kenobi obi1kenobi mentioned this issue Dec 23, 2023
Merged
@obi1kenobi obi1kenobi mentioned this issue Aug 18, 2024
Closed
8 tasks
@mrnossiom mrnossiom mentioned this issue Aug 28, 2024
Merged
@obi1kenobi obi1kenobi mentioned this issue Sep 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lint Area: new or existing lint E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add trait_added_supertrait mrnossiom/cargo-semver-checks
1 participant
@obi1kenobi