Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to docs that trustfall is rarely the slowest part of query execution #456

Open
u9g opened this issue Aug 21, 2023 · 1 comment
Open
Labels
A-docs Area: documentation for the query language or library APIs E-easy Call for participation: experience needed to fix: easy / not much (good first issue) E-help-wanted Call for participation: help is requested to fix this issue.

Comments

@u9g
Copy link
Contributor

u9g commented Aug 21, 2023

Often times the slowest part of query execution is the user's adapter code, let's add that to the docs.

@obi1kenobi
Copy link
Owner

We should also add the advice about compiling Trustfall and its key dependencies for running queries in release mode, because that's the only exception to the "Trustfall isn't the slow part" here. Running Trustfall in debug mode can be a 10x slowdown, and having it compile in release mode pays for itself since one doesn't update (and therefore recompile) Trustfall every day.

@obi1kenobi obi1kenobi added A-docs Area: documentation for the query language or library APIs E-help-wanted Call for participation: help is requested to fix this issue. E-easy Call for participation: experience needed to fix: easy / not much (good first issue) labels Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for the query language or library APIs E-easy Call for participation: experience needed to fix: easy / not much (good first issue) E-help-wanted Call for participation: help is requested to fix this issue.
Projects
None yet
Development

No branches or pull requests

2 participants