Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OptCached.java:45-55: Refactor OptCache Class Currently,... #2820

Closed
0pdd opened this issue Jan 26, 2024 · 2 comments
Closed

OptCached.java:45-55: Refactor OptCache Class Currently,... #2820

0pdd opened this issue Jan 26, 2024 · 2 comments
Assignees
Milestone

Comments

@0pdd
Copy link

0pdd commented Jan 26, 2024

The puzzle 2790-ef16f785 from #2790 has to be resolved:

* @todo #2790:30min Refactor OptCache Class
* Currently, we have some concerns about the implementation of OptCache.
* It appears that the code is a bit too complicated.
* The OptCache class takes XMIR as an argument in OptCache#apply
* and the path to the same XMIR in the constructor, which seems odd.
* We need to consider how to refactor this class.
* Furthermore, the current implementation of OptCache
* and OptimizationTask has a similar logic of returning either from the cache
* or applying a default optimization.
* For more information, please refer to this discussion:
* <a href=“https://github.com/objectionary/eo/pull/2808#discussion_r1464941944”>issue</a>.

The puzzle was created by rultor on 26-Jan-24.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@Yanich96
Copy link
Contributor

@maxonfjvipon assign me, please

@maxonfjvipon maxonfjvipon added this to the Urgent milestone Feb 2, 2024
@0pdd 0pdd closed this as completed Oct 23, 2024
@0pdd
Copy link
Author

0pdd commented Oct 23, 2024

The puzzle 2790-ef16f785 has disappeared from the source code, that's why I closed this issue.

0pdd referenced this issue Oct 23, 2024
…cache

fix(#1426): parse, optimize, shake and verify with cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants