Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to java client 0.30.1 #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update to java client 0.30.1 #53

wants to merge 1 commit into from

Conversation

objectiser
Copy link
Owner

No description provided.

@objectiser
Copy link
Owner Author

@jpkrohling Can you try this PR - I think there is an issue with the jaeger-thrift (no-shadow) dependency being pulled in.

Try starting up the jaeger all-in-one in docker and then from the simple/accountmgr folder run:

mvn spring-boot:run -DJAEGER_SERVICE_NAME=myservice

I am getting the following dependencies:

[INFO] +- io.jaegertracing:jaeger-client:jar:0.30.1:compile
[INFO] |  +- io.jaegertracing:jaeger-thrift:jar:0.30.1:compile
[INFO] |  +- io.jaegertracing:jaeger-core:jar:0.30.1:compile
[INFO] |  |  +- io.opentracing:opentracing-api:jar:0.31.0:compile
[INFO] |  |  +- io.opentracing:opentracing-util:jar:0.31.0:compile
[INFO] |  |  +- com.google.code.gson:gson:jar:2.8.0:compile
[INFO] |  |  \- org.slf4j:slf4j-api:jar:1.7.25:compile
[INFO] |  +- io.jaegertracing:jaeger-thrift:jar:no-shadow:0.30.1:compile
[INFO] |  \- io.jaegertracing:jaeger-tracerresolver:jar:0.30.1:compile
[INFO] |     \- io.opentracing.contrib:opentracing-tracerresolver:jar:0.1.4:compile

notice the 'no-shadow' version as well as the no classifier version of jaeger-thrift. Resulting in class not found on the non-shaded classes. Something strange going on - can you see if you can reproduce?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant