Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict peer-dependencies of latest Storybook 7 @7.0.21 when install latest loki@0.32.0 #464

Closed
anatoly-ivashov opened this issue Jun 16, 2023 · 12 comments

Comments

@anatoly-ivashov
Copy link

When you install the latest version of storybook@7.0.21 and then install the latest version of loki@0.32.0, installing loki gives an error in peer-dependencies of @storybook/react. Storybook installing @storybook/react@^7, loki installing @storybook/react@^6.

image

@hamitovm
Copy link

I have the same problem with Storybook 7 @7.0.22.
Helps yarn add loki --dev, but it doesn't work in github actions.
image

@ahsan-rao
Copy link

I am also facing the same issue when trying to install the latest loki and storybook. Any one find a solution to this yet?

@GRusla-n
Copy link

GRusla-n commented Jun 26, 2023

For me works add overrides to package.json:
"overrides": { "loki": { "@storybook/react": "$@storybook/react" } }

@Greed2kk
Copy link

"overrides": { "loki": { "@storybook/react": "$@storybook/react" } }

nice!

@ValeraKaktotak
Copy link

For me works add overrides to package.json: "overrides": { "loki": { "@storybook/react": "$@storybook/react" } }

ty man!

@JS-NinjaNN
Copy link

For me works add overrides to package.json: "overrides": { "loki": { "@storybook/react": "$@storybook/react" } }

Works for me, thanks man!

@squidjam
Copy link

I don't think we should accept overrides as a solution when there is a pull request waiting to get approved that could solve this issue?
Could the repo owners please check and approve the following PR, please?
#476

@aalexxandr
Copy link

For me works add overrides to package.json: "overrides": { "loki": { "@storybook/react": "$@storybook/react" } }

it's work. Thanks!

@gidztech
Copy link
Contributor

This should no longer be an issue now that https://github.com/oblador/loki/releases/tag/v0.33.0 is released

@oblador oblador closed this as completed Oct 31, 2023
@qooban
Copy link
Contributor

qooban commented Nov 29, 2023

There's still peer dependency issue when installing loki:

npm install --save-dev loki

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @loki/integration-react@0.33.0
npm WARN Found: @storybook/react@7.5.2
npm WARN node_modules/@storybook/react
npm WARN   dev @storybook/react@"^7.5.2" from the root project
npm WARN   3 more (@storybook/preset-react-webpack, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peerOptional @storybook/react@"^5 || ^6" from @loki/integration-react@0.33.0
npm WARN node_modules/loki/node_modules/@loki/integration-react
npm WARN   @loki/integration-react@"^0.33.0" from loki@0.33.0
npm WARN   node_modules/loki
npm WARN 
npm WARN Conflicting peer dependency: @storybook/react@6.5.16
npm WARN node_modules/@storybook/react
npm WARN   peerOptional @storybook/react@"^5 || ^6" from @loki/integration-react@0.33.0
npm WARN   node_modules/loki/node_modules/@loki/integration-react
npm WARN     @loki/integration-react@"^0.33.0" from loki@0.33.0
npm WARN     node_modules/loki

Created #491 hoping that it can fix it.

@gidztech
Copy link
Contributor

gidztech commented Dec 1, 2023

There's still peer dependency issue when installing loki:

npm install --save-dev loki

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @loki/integration-react@0.33.0
npm WARN Found: @storybook/react@7.5.2
npm WARN node_modules/@storybook/react
npm WARN   dev @storybook/react@"^7.5.2" from the root project
npm WARN   3 more (@storybook/preset-react-webpack, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peerOptional @storybook/react@"^5 || ^6" from @loki/integration-react@0.33.0
npm WARN node_modules/loki/node_modules/@loki/integration-react
npm WARN   @loki/integration-react@"^0.33.0" from loki@0.33.0
npm WARN   node_modules/loki
npm WARN 
npm WARN Conflicting peer dependency: @storybook/react@6.5.16
npm WARN node_modules/@storybook/react
npm WARN   peerOptional @storybook/react@"^5 || ^6" from @loki/integration-react@0.33.0
npm WARN   node_modules/loki/node_modules/@loki/integration-react
npm WARN     @loki/integration-react@"^0.33.0" from loki@0.33.0
npm WARN     node_modules/loki

Created #491 hoping that it can fix it.

It looks like it was updated in on the main loki package (https://github.com/oblador/loki/blob/master/packages/loki/package.json#L57) but not in the integration-react one. This issue only comes through as a warning, whereas the original was an error that broke the build. It doesn't seem to break anything currently (at least for me), but updating the other package is a good idea.

@v-nvtsk
Copy link

v-nvtsk commented Mar 21, 2024

Got not warning, but error installing loki@0.34.0

npm WARN ERESOLVE overriding peer dependency
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: loki@0.34.0
npm ERR! Found: @storybook/react@8.0.2
npm ERR! node_modules/@storybook/react
npm ERR!   peerOptional @storybook/react@"^5 || ^6 || ^7" from @loki/integration-react@0.34.0      
npm ERR!   node_modules/loki/node_modules/@loki/integration-react
npm ERR!     @loki/integration-react@"^0.34.0" from loki@0.34.0
npm ERR!     node_modules/loki
npm ERR!       dev loki@"^0.34.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peerOptional @storybook/react@"^5 || ^6 || ^7" from loki@0.34.0
npm ERR! node_modules/loki
npm ERR!   dev loki@"^0.34.0" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @storybook/react@7.6.17
npm ERR! node_modules/@storybook/react
npm ERR!   peerOptional @storybook/react@"^5 || ^6 || ^7" from loki@0.34.0
npm ERR!   node_modules/loki
npm ERR!     dev loki@"^0.34.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR!
npm ERR! For a full report see:
npm ERR! C:\Users\user\AppData\Local\npm-cache\_logs\2024-03-21T09_17_19_110Z-eresolve-report.txt  

npm ERR! A complete log of this run can be found in: C:\Users\user\AppData\Local\npm-cache\_logs\2024-03-21T09_17_19_110Z-debug-0.log

So there still peer dependency issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests