Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all values count #13

Open
6 tasks
Etua opened this issue Dec 3, 2022 · 0 comments
Open
6 tasks

Make all values count #13

Etua opened this issue Dec 3, 2022 · 0 comments

Comments

@Etua
Copy link
Collaborator

Etua commented Dec 3, 2022

Currently raptor10.c contains many arguments to the functions which are never accessed or variables which are assigned value and again, ignored later.
While it would be trivial to simply delete them, they might indicate incomplete implementation of the RFC. For this reason, they should be reviewed one by one. Not to overcrowd the issue list, I created a list of functions to review. An element should be marked as complete, once all arguments and variables are accessed or it is clearly stated in the comment why they are not.

  • r10_Trip
  • r10_build_LDPC_submat (initial value is instantly overwritten)
  • r10_build_Half_submat
  • r10_build_LT_mat
  • r10_LTEnc
  • r10_decode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant