Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review structures involved in 'drains' relationship (continued from #2335) #2338

Closed
1 task done
ghost opened this issue Mar 7, 2022 · 2 comments
Closed
1 task done
Labels
autoclosed-unfixed This issue has been closed automatically. Stale

Comments

@ghost
Copy link

ghost commented Mar 7, 2022

See 'major and minor kidney calyces miss-classified as renal venous blood vessel #2335' for the origin and context of this ticket. Briefly, anatomical structures that are not veins were incorrectly included in axioms with the 'drains' relationship, which is currently restricted to the domain 'vein'.
#2335 / #2336 resolved the short-term fix. This ticket tracks investigation on the long-term fixes.

Short-term fix (DONE):

  • remove 'drains' relationships from major and minor calyx terms.

Long-term fixes (TO DO):
Action items, if any, can be decided after oborel/obo-relations#699 is resolved.

  • Check for other potential examples - remove range of drains (for testing purposes only); find terms that are the subject of a drains relationships that are not subclasses of vein.
  • Add high level disjoints to catch issues like this in future
  • TBD - remove domain of 'drains' in RO?
  • consider removing axiom:
    'kidney calyx' 'part of' some 'renal pelvis'~~
@ghost ghost self-assigned this Mar 7, 2022
@github-actions
Copy link

github-actions bot commented Sep 4, 2022

This issue has not seen any activity in the past 6 months; it will be closed automatically in one year from now if no action is taken.

@github-actions github-actions bot added the Stale label Sep 4, 2022
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

This issue has been closed automatically because it has not been updated in 18 months. Please re-open if you still need this to be addressed.

@github-actions github-actions bot added the autoclosed-unfixed This issue has been closed automatically. label Sep 5, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoclosed-unfixed This issue has been closed automatically. Stale
Projects
None yet
Development

No branches or pull requests

0 participants