Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxon disjoints missing from locally built uberon.owl #2533

Closed
balhoff opened this issue Jun 14, 2022 · 12 comments · Fixed by #3102
Closed

taxon disjoints missing from locally built uberon.owl #2533

balhoff opened this issue Jun 14, 2022 · 12 comments · Fixed by #3102

Comments

@balhoff
Copy link
Member

balhoff commented Jun 14, 2022

Please correct me if I'm missing it, but as far as I can tell, the Uberon build doesn't use taxslim-disjoint-over-in-taxon.owl anywhere, or generate the axioms it contains, like:

('in taxon' some Opisthokonta) DisjointWith ('in taxon' some Viridiplantae)

Without these axioms, taxon constraints don't do anything in OWL EL. I would expect to find these GCIs in the final Uberon product. I'm running into this while trying to test some edits for #2349.

@balhoff balhoff added the tech label Jun 14, 2022
@balhoff
Copy link
Member Author

balhoff commented Jun 14, 2022

I do see a disjoint axiom like that in #2367; can someone explain where they're used?

@balhoff
Copy link
Member Author

balhoff commented Jun 14, 2022

Now I see that these axioms are present in the released ext.owl, but not the version I built locally by running make ext.owl. What am I doing wrong?

@balhoff balhoff changed the title Uberon build doesn't seem to use taxon constraints taxon disjoints missing from locally built ext.owl Jun 14, 2022
@matentzn
Copy link
Contributor

This is so weird. In ext.owl they must be coming in from through CL or something..

Can you summarise the functional problem with these axioms missing? I think that the for the subset generation, which is the place using the taxon constraints are used in Uberon, some other owltools based step is invoked after the fact, but the disjointness axioms are not shipped out.. From your understanding, should the taxon disjointness axioms be present in the release? So that it works with, for example, your OBO taxon plugin?

@matentzn matentzn self-assigned this Jun 27, 2022
@balhoff
Copy link
Member Author

balhoff commented Jul 12, 2022

I think the taxon constraints should be working for any DL coherency check, not just to generate subsets. If you don't have axioms like ('in taxon' some X) DisjointWith ('in taxon' some Y), then there is no way to infer an unsatisfiable class based on taxon constraints (using OWL EL). Personally I think the taxon disjointness axioms should be in the release. They're definitely needed for the Protege taxon constraints plugin to work.

To go further in helping out ELK here, we also need ('in taxon' some X) DisjointWith ('in taxon' some (not X)) (at GO).

@matentzn
Copy link
Contributor

@cmungall Do you see any reason not to release the unfolded taxon constraints in Uberon?

@cmungall
Copy link
Member

Do you see any reason not to release the unfolded taxon constraints in Uberon?

To be pedantic, axioms like

('in taxon' some X) DisjointWith ('in taxon' some Y)

are not themselves taxon constraints. This is part of the axiomatization of NCBITaxon.

The documentation for this is very buried:
https://github.com/obophenotype/ncbitaxon/blob/master/subsets/README.md

I have no problem in incorporating these in a merged release file accompanying the taxon constraints themselves. But be aware from the point of view of assembly non-redundant subsets of ontologies using base files, these would not be included. They should come from some kind of ncbitaxon-base, were such a thing to exist

@shawntanzk
Copy link
Collaborator

Action item:

  • Figure out where ('in taxon' some X) DisjointWith ('in taxon' some Y) live (look through uberon.makefile)
  • Specify new component for these axioms (make sure to only import needed axioms - ie related to taxa we use)
  • Make PR and see what breaks

@github-actions
Copy link

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

@anitacaron
Copy link
Collaborator

  • Figure out where ('in taxon' some X) DisjointWith ('in taxon' some Y) live (look through uberon.makefile)

This is not in the pipeline right now. We need to merge the taxslim-disjoint-over-in-taxon.owl as Jim said.

A related issue that will fix this #2707

@anitacaron anitacaron changed the title taxon disjoints missing from locally built ext.owl taxon disjoints missing from locally built uberon.owl Nov 15, 2023
@anitacaron anitacaron linked a pull request Nov 15, 2023 that will close this issue
@anitacaron
Copy link
Collaborator

anitacaron commented Nov 15, 2023

After refactoring the Makefile, the ext.owl artefact was removed because it was the same as uberon.owl. For now, the disjoints are only added in the QC.

Copy link

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

@github-actions github-actions bot added the Stale label May 15, 2024
@gouttegd
Copy link
Collaborator

gouttegd commented Oct 8, 2024

Taxon disjointness axioms are now included in uberon.owl, for all taxa that are imported by Uberon. Closing here.

@gouttegd gouttegd closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants