Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to composite pipeline #3140

Closed
anitacaron opened this issue Dec 6, 2023 · 1 comment
Closed

Improvements to composite pipeline #3140

anitacaron opened this issue Dec 6, 2023 · 1 comment

Comments

@anitacaron
Copy link
Collaborator

Note that there are still things that can be improved, including:

  • The “merge species” step leaves behind a bunch of class declaration axioms for the taxon-specific classes that have been “merged“ into their taxon-neutral equivalent. That is, when (for example) EMAPA:17443 is replaced by UBERON:00005695 and (BFO:0000050 some NCBITaxon:10090), we still have a class declaration axiom for EMAPA:17443:
<!-- http://purl.obolibrary.org/obo/EMAPA_17443 -->
<owl:Class rdf:about="http://purl.obolibrary.org/obo/EMAPA_17443">
    <rdfs:subClassOf rdf:resource="http://www.w3.org/2002/07/owl#Thing"/>
</owl:Class>
  • General class axioms are not translated. If we have, say, a GCA that says
FBbt:X and (BFO:0000050 some FBbt:Y) SubClassOf BFO:0000050 some FBbt:Z

and upon merging FBbt:X is merged into UBERON:X and (BFO:0000050 some NCBITaxon:7227), the GCA will still refer to FBbt:X.

  • We have a bunch of FBgn pseudo-terms from the FlyBase ontologies, which in my opinion don’t belong to composite-metazoan.

Those problems are not new – they already existed in previous versions of composite-metazoan. They should be easier to fix now, but I’d rather do that as a separate PR (possibly several separate PRs). My aim for this PR was strictly to replace the existing pipeline by one that is easier to maintain, but that is otherwise equivalent (including in its bugs! :P ).

Originally posted by @gouttegd in #3129 (comment)

@anitacaron
Copy link
Collaborator Author

Sorry, it's the same as #3132

@anitacaron anitacaron closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant