From 1896acecf5573efe8b0fe091ac37038bbc4930ca Mon Sep 17 00:00:00 2001
From: Brandon Johnson <brandon.johnson@bluemedora.com>
Date: Thu, 28 Jul 2022 13:34:37 -0400
Subject: [PATCH] stop the service before rollback

---
 updater/cmd/updater/main.go         | 26 +++++++++++++++++++++++++-
 updater/internal/install/install.go | 17 +++++------------
 2 files changed, 30 insertions(+), 13 deletions(-)

diff --git a/updater/cmd/updater/main.go b/updater/cmd/updater/main.go
index 9c88f4616..3ad3c6220 100644
--- a/updater/cmd/updater/main.go
+++ b/updater/cmd/updater/main.go
@@ -23,10 +23,12 @@ import (
 	"time"
 
 	"github.com/observiq/observiq-otel-collector/packagestate"
+	"github.com/observiq/observiq-otel-collector/updater/internal/action"
 	"github.com/observiq/observiq-otel-collector/updater/internal/install"
 	"github.com/observiq/observiq-otel-collector/updater/internal/logging"
 	"github.com/observiq/observiq-otel-collector/updater/internal/path"
 	"github.com/observiq/observiq-otel-collector/updater/internal/rollback"
+	"github.com/observiq/observiq-otel-collector/updater/internal/service"
 	"github.com/observiq/observiq-otel-collector/updater/internal/state"
 	"github.com/observiq/observiq-otel-collector/updater/internal/version"
 	"github.com/open-telemetry/opamp-go/protobufs"
@@ -68,12 +70,34 @@ func main() {
 	}
 
 	rb := rollback.NewRollbacker(logger, installDir)
+	// Stop the service before backing up the install directory;
+	// We want to stop as early as possible so that we don't hit the collector's timeout
+	// while it waits to be shutdown.
+	service := service.NewService(logger, installDir)
+	if err := service.Stop(); err != nil {
+		logger.Error("Failed to stop service", zap.Error(err))
+		fail(logger, installDir)
+	}
+	// Record that we stopped the service
+	rb.AppendAction(action.NewServiceStopAction(service))
+
+	logger.Debug("Stopped the service")
+
 	if err := rb.Backup(); err != nil {
 		logger.Error("Failed to backup", zap.Error(err))
+
+		// Set the state to failed before rollback so collector knows it failed
+		if setErr := monitor.SetState(packagestate.CollectorPackageName, protobufs.PackageStatus_InstallFailed, err); setErr != nil {
+			logger.Error("Failed to set state on backup failure", zap.Error(setErr))
+		}
+
+		rb.Rollback()
+
+		logger.Error("Rollback complete")
 		fail(logger, installDir)
 	}
 
-	installer := install.NewInstaller(logger, installDir)
+	installer := install.NewInstaller(logger, installDir, service)
 	if err := installer.Install(rb); err != nil {
 		logger.Error("Failed to install", zap.Error(err))
 
diff --git a/updater/internal/install/install.go b/updater/internal/install/install.go
index be11e1f1e..fc740b845 100644
--- a/updater/internal/install/install.go
+++ b/updater/internal/install/install.go
@@ -38,26 +38,19 @@ type Installer struct {
 }
 
 // NewInstaller returns a new instance of an Installer.
-func NewInstaller(logger *zap.Logger, installDir string) *Installer {
-	namedLogger := logger.Named("installer")
+func NewInstaller(logger *zap.Logger, installDir string, service service.Service) *Installer {
 	return &Installer{
 		latestDir:  path.LatestDir(installDir),
-		svc:        service.NewService(namedLogger, installDir),
+		svc:        service,
 		installDir: installDir,
-		logger:     namedLogger,
+		logger:     logger.Named("installer"),
 	}
 }
 
 // Install installs the unpacked artifacts in latestDir to installDir,
-// as well as installing the new service file using the installer's Service interface
+// as well as installing the new service file using the installer's Service interface.
+// It then starts the service.
 func (i Installer) Install(rb rollback.ActionAppender) error {
-	// Stop service
-	if err := i.svc.Stop(); err != nil {
-		return fmt.Errorf("failed to stop service: %w", err)
-	}
-	rb.AppendAction(action.NewServiceStopAction(i.svc))
-	i.logger.Debug("Service stopped")
-
 	// install files that go to installDirPath to their correct location,
 	// excluding any config files (logging.yaml, config.yaml, manager.yaml)
 	if err := installFiles(i.logger, i.latestDir, i.installDir, rb); err != nil {