Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unresolved imports should error in fenced code blocks #1659

Open
mbostock opened this issue Sep 13, 2024 · 1 comment
Open

Unresolved imports should error in fenced code blocks #1659

mbostock opened this issue Sep 13, 2024 · 1 comment
Labels
bug Something isn’t working

Comments

@mbostock
Copy link
Member

We translate static imports to dynamic imports, but this should error rather than resolve to undefined:

import {doesNotExist} from "./module.js";
@mbostock mbostock added the bug Something isn’t working label Sep 13, 2024
@mbostock
Copy link
Member Author

Currently the above is translated into (approximately):

const {doesNotExist} = await import("./_import/module.js");

We’ll need to do something like this instead:

const $module = await import("./_import/module.js");
if (!("doesNotExist" in $module)) throw new SyntaxError("The requested module './module.js' does not provide an export named 'doesNotExist'");
const {doesNotExist} = $module;

Where $module doesn’t collide with any referenced symbol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working
Projects
None yet
Development

No branches or pull requests

1 participant