Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uncaught TypeError: HTML comments with template literals and string interpolation #375

Closed
cinxmo opened this issue Dec 12, 2023 · 0 comments · Fixed by #1416 or #1441
Closed

uncaught TypeError: HTML comments with template literals and string interpolation #375

cinxmo opened this issue Dec 12, 2023 · 0 comments · Fixed by #1416 or #1441
Assignees
@mbostock
Labels
bug Something isn’t working

Comments

@cinxmo
Copy link
Contributor

cinxmo commented Dec 12, 2023

In a markdown file, add:

<!--This is a comment.
Comments are not displayed in the browser ${'hello'}
-->

In the browser console, this shows up:
Screenshot 2023-12-12 at 4 57 04 PM
@cinxmo cinxmo added the bug Something isn’t working label Dec 12, 2023
Fil added a commit that referenced this issue Dec 13, 2023
@Fil
one way to fix #375: if the target element (for clear and display) do…
e48a10f 
…esn't exist, create a (non-attached) node to avoid erroring.
@Fil Fil mentioned this issue Dec 13, 2023
Closed
@cinxmo cinxmo added this to the General availability milestone Jan 16, 2024
@cinxmo cinxmo assigned Fil and unassigned Fil Jan 18, 2024
This was referenced Jan 23, 2024
Closed
Closed
@mbostock mbostock modified the milestones: General availability, Future Feb 13, 2024
@mbostock mbostock removed this from the Future milestone Mar 24, 2024
@Fil Fil mentioned this issue May 10, 2024
Closed
@Fil Fil mentioned this issue Jun 1, 2024
Merged
@mbostock mbostock mentioned this issue Jun 4, 2024
Merged
@mbostock mbostock self-assigned this Jun 4, 2024
@mbostock mbostock reopened this Jun 6, 2024
This was referenced Jun 6, 2024
Closed
Merged
Fil added a commit that referenced this issue Jun 7, 2024
@Fil
test #375.
0449a41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbostock mbostock

Labels
bug Something isn’t working
Projects
None yet
Milestone
No milestone
3 participants
@Fil @mbostock @cinxmo