-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileAttachment.arquero #1509
FileAttachment.arquero #1509
Conversation
A question would be, should the |
Okay, I added support for CSV, TSV, and JSON. |
I've added a bit of documentation. I this this raises another question: if we want to generalize this approach, shouldn't we have a duckdb method as well, e.g. |
We certainly could add a DuckDB method, but I don’t think that should block this PR, and I think it makes slightly less sense in the DuckDB case because typically a database has multiple tables and so you don’t want to give the file attachment primacy (i.e., it’s better to use |
Added support for Apache Parquet files (and preloading which is a bit tricky because we only need to additionally preload parquet-wasm when using an Apache Parquet file with Arquero). Made the Arquero loader detection a bit more robust considering the file extension when the MIME type isn’t sufficient. Also tweaked the documentation a bit. PTAL @Fil thank you! |
Ref. #1506 (review)