Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static dot #153

Closed
wants to merge 3 commits into from
Closed

static dot #153

wants to merge 3 commits into from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Nov 12, 2023

Looks like it might work, but I'd like to share some code between client rendering and SSR — one is in TypeScript and the other one is JS. This might give us ideas to SSR other types of contents, too.

TODO:

  • detect interpolation

closes #141 for DOT

@Fil Fil requested a review from mbostock November 12, 2023 18:03
@Fil Fil mentioned this pull request Nov 12, 2023
1 task
@mbostock
Copy link
Member

mbostock commented Nov 12, 2023

I want us to implement bundling (and minification) for the client bundle. Maybe let’s do that first so we have a way to share code between client and server? #61

@mbostock
Copy link
Member

(Also SSR for Graphviz is great because it can be quite slow otherwise!!)

@Fil Fil mentioned this pull request Dec 3, 2023
src/markdown.ts Outdated Show resolved Hide resolved
src/markdown.ts Outdated Show resolved Hide resolved
@Fil Fil marked this pull request as draft December 4, 2023 09:55
@Fil Fil closed this Feb 2, 2024
@Fil
Copy link
Contributor Author

Fil commented Feb 2, 2024

superseded by #413

@Fil Fil deleted the fil/static-dot branch February 2, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants