Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use maxItems for unbounded select #1618

Merged
merged 1 commit into from
Aug 28, 2024
Merged

use maxItems for unbounded select #1618

merged 1 commit into from
Aug 28, 2024

Conversation

mbostock
Copy link
Member

Supersedes #1493.

@mbostock mbostock requested review from Fil and mythmon August 28, 2024 20:54
@mbostock mbostock mentioned this pull request Aug 28, 2024
Closed
mythmon
mythmon approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@mythmon mythmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally, and it worked great

@mbostock mbostock merged commit 1d8844c into main Aug 28, 2024
4 checks passed
@mbostock mbostock deleted the mbostock/prompt-max-items branch August 28, 2024 22:04
Fil
Fil reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (ex post) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fil Fil Fil left review comments

@mythmon mythmon mythmon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbostock @Fil @mythmon