Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use maxItems for unbounded select #1618

Merged
merged 1 commit into from
Aug 28, 2024
Merged

use maxItems for unbounded select #1618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,7 @@ export async function promptDeployTarget(
} else {
const chosenWorkspace = await effects.clack.select<{value: WorkspaceResponse; label: string}[], WorkspaceResponse>({
message: "Which Observable workspace do you want to use?",
maxItems: Math.max(process.stdout.rows - 4, 0),
options: currentUser.workspaces
.map((w) => ({value: w, label: formatUser(w)}))
.sort((a, b) => b.value.role.localeCompare(a.value.role) || a.label.localeCompare(b.label)),
Expand All @@ -757,6 +758,7 @@ export async function promptDeployTarget(
if (existingProjects.length > 0) {
const chosenProject = await effects.clack.select<{value: string | null; label: string}[], string | null>({
message: "Which project do you want to use?",
maxItems: Math.max(process.stdout.rows - 4, 0),
options: [
{value: null, label: "Create a new project"},
...existingProjects
Expand Down