Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes the selection UI on sql code block displays #1740

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Oct 10, 2024

Removes the selection column UI on the displayed result of a sql code block, since this interaction is not operational.

In the case of a named block, we could imagine reenabling it if it would drive changes to the values passed to id; but it's not the case at the moment (and I'm not sure it would be the best UX anyway).

@Fil Fil requested a review from mbostock October 10, 2024 12:53
@Fil Fil marked this pull request as draft October 10, 2024 13:00
@Fil Fil force-pushed the fil/sql-table-no-select branch from a0cd633 to 0ef1eba Compare October 10, 2024 13:06
@Fil Fil marked this pull request as ready for review October 10, 2024 13:06
@Fil Fil enabled auto-merge (squash) October 10, 2024 13:11
@Fil Fil merged commit 92670c6 into main Oct 10, 2024
4 checks passed
@Fil Fil deleted the fil/sql-table-no-select branch October 10, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants