adopt picocolors #1769
Merged
adopt picocolors #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It works in local tests (with say, 
When I look at the source code, the logic is defaulting to using colors when I think it's a fair assumption, and that we should merge this in nonetheless, when we're ready. |
|
That’s a pre-existing problem with Cloud logs, right? E.g., this oss-analytics deploy. This makes it worse, but seems like something that shouldn’t block this PR. 
|
|
OK then! |
Fil
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces our hand-rolled version with the popular picocolors, offering support for
NO_COLORand relying on picocolor’s own color support detection. As an alternative, we could also use yoctocolors which already useshasColors… but I figured picocolors is nice because it’s already a dependency of clack.Related #1764.