Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set max-width on footer, align to content, buttons equal size #189

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

trebor
Copy link
Contributor

@trebor trebor commented Nov 16, 2023

a quick patch to set max-width on the footer to 640px, and equalize the prev & next button sizes.

closes: #188.

looks like this:

image

@trebor trebor requested review from Fil and mbostock November 16, 2023 22:01
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but this removes the auto margins on the footer, which breaks the footer layout on wide screens.

Before (main):
Screenshot 2023-11-16 at 4 32 47 PM

After (this branch):
Screenshot 2023-11-16 at 4 32 39 PM

I think you want to revert the change to L51–52, but keep everything else.

@Fil Fil requested a review from mbostock November 17, 2023 05:02
@mbostock mbostock merged commit b1462aa into main Nov 17, 2023
1 check passed
@mbostock mbostock deleted the trebor/improve-prev-next branch November 17, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve prev/next button treatment
3 participants