-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pager improvements #192
pager improvements #192
Conversation
Related (though not a comment on this PR _per se_), as I was just working on the sidebar, I wanted to change the behavior wrt the **title** config option. For me, it's surprising that this option would make the top link to / appear (or disappear).
I'd like to suggest instead that the title option just changes the text of that link, which would be always present (unless of course there is only 1 page). Otherwise, we must fix the bug that makes the whole navigation menu bold if there is no title. (This bug is already present in main; my suggestion fixes by way of consequence.) When the first link goes to the home page (which in my suggestion would be always), we should skip pages[0] if it is /index, to avoid a repetition. This in turn would allow the prev/next links to include the /index iff the user adds that page as the first element of config.pages (it would be the default if you don't specify config.pages). this comment is now #195 |
My second comment is on the use of If we wanted to not use the classes .prev and .next, we could maybe use a (more semantic) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll act on my first comment #192 (comment) in a separate PR.
Second comment about the markup is a non-blocking question.
What do you not like about the markup? I do like the rel=prev/next semantic approach though! As for clashing, it clashes if users define their own I agree with the title and |
148e00b
to
5cccbbf
Compare
This…
/index
as the implicit first page (if there’s a title set)/index
as appropriateobservablehq-
prefixed idspager
functionpager
functionExample: