handle invalid front-matter errors #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no answer from upstream yet, let's get this merged? |
cinxmo
reviewed
Nov 30, 2023
src/markdown.ts
Outdated
| // https://github.com/jonschlinkert/gray-matter/blob/ce67a86dba419381db0dd01cc84e2d30a1d1e6a5/index.js#L225 | ||
| // eslint-disable-next-line | ||
| // @ts-ignore | ||
| matter.clearCache!(); |
There was a problem hiding this comment.
is this an undocumented method? I don't see it in the types... (but I see the code in your comment)
There was a problem hiding this comment.
it is! I'd prefer for them to fix that bug, but in the meantime it's the best I can do
There was a problem hiding this comment.
do we really want to throw instead of just logging the error? The rest of the page should render 🤔
There was a problem hiding this comment.
You can bypass the cache by passing in empty options:
So let’s do that. Then you won’t need the try catch or clearCache call.
Revert unrelated change.
cinxmo
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #215
or just wait and see if jonschlinkert/gray-matter#166 is closed?