Streaming deploys #249
Merged
Streaming deploys #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing I didn't do here that I could imagine is having a sort of build pipeline, where we could build the next file while the previous file is uploading. This might become important for very large projects, but it seems to disruptive to introduce into the build process right now. |
mbostock
reviewed
Nov 28, 2023
mythmon
force-pushed
the
mythmon/streaming-uploads
branch
from
e343524 to
c084f5e
Compare
|
I rebased this on main and did some minor clean up to sync it to Matt's latest PR version. This is ready for review now. |
mbostock
reviewed
Nov 29, 2023
mbostock
reviewed
Nov 29, 2023
mbostock
reviewed
Nov 29, 2023
mbostock
reviewed
Nov 29, 2023
mbostock
reviewed
Nov 29, 2023
mbostock
requested changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #187, and is going to be a bit chaotic until that merges. All my changes are in the last commit.
The idea here is that instead of deploying the existing
distdirectory, as done in #187, the deploy command runs its own independent build command. This will be important in the future because we plan to have that build be different than a normal dist-based build.Then, given that the files generated for the deploy aren't all that interesting except to immediately upload them to the server, this PR now skips writing them to disk. With the exception of data loaders, files are uploaded straight from memory to the deploy server. Data loaders still write files to disk, so they can participate in caching. These use the same path as normal builds, so we can't introduce differences during deploy builds with this model.