Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address post-merge deploy PR comments. #271

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Address post-merge deploy PR comments. #271

merged 1 commit into from
Nov 29, 2023

Conversation

mcglincy
Copy link
Contributor

Address Mike's comments on #187.

@mcglincy mcglincy requested review from mbostock and mythmon November 29, 2023 04:10
mbostock
mbostock approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@mcglincy mcglincy merged commit a2c99eb into main Nov 29, 2023
1 check passed
@mcglincy mcglincy deleted the mcglincy/deploy-comments-followup branch November 29, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock mbostock approved these changes

@mythmon mythmon Awaiting requested review from mythmon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcglincy @mbostock