Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build uses a stale cache #296

Merged
merged 3 commits into from
Dec 1, 2023
Merged

build uses a stale cache #296

merged 3 commits into from
Dec 1, 2023

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Dec 1, 2023

closes #140

I had fun writing the test!

@Fil Fil requested review from mbostock and cinxmo December 1, 2023 10:44
cinxmo
cinxmo reviewed Dec 1, 2023
View reviewed changes
test/dataloaders-test.ts Outdated Show resolved Hide resolved
mbostock
mbostock reviewed Dec 1, 2023
View reviewed changes
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not a fan of boolean positional arguments because it’s hard to know what “true” means from the call site. (Admittedly TypeScript helps with this.) How about passing {useStale = false} = {} options instead?

@Fil
Copy link
Contributor Author

Fil commented Dec 1, 2023

done

@Fil Fil merged commit 21772b1 into main Dec 1, 2023
1 check passed
@Fil Fil deleted the fil/use-stale branch December 1, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cinxmo cinxmo cinxmo approved these changes

@mbostock mbostock mbostock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignore loader cache modification time during build
3 participants
@Fil @mbostock @cinxmo