A slightly better TOC #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add intermediate h1 sections - skip subtitles (h1+h2) closes #281
mbostock
reviewed
Dec 1, 2023
src/render.ts
Outdated
| @@ -124,7 +124,7 @@ interface Header { | |||
| } | |||
|
|
|||
| function findHeaders(parseResult: ParseResult): Header[] { | |||
| return Array.from(parseHTML(parseResult.html).document.querySelectorAll("h2")) | |||
| return Array.from(parseHTML(parseResult.html).document.querySelectorAll("h1:not(:first-of-type), h2:not(h1 + h2)")) | |||
There was a problem hiding this comment.
Maybe we could create a shared file with export const selectors = ["h1:not(:first-of-type)", "h2:not(h1 + h2)"] that we can use on both the client and server?
There was a problem hiding this comment.
Alternatively it could get baked-in to the generated page code (so that the user can override it), and then passed to enableToc(selectors).
There was a problem hiding this comment.
Now passing it via a data-selector property in the toc. Next step would be to make it configurable but this is out of scope for this PR (and I'm not sure we should hurry on configurability).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #281